Skip to content

Add access-log pattern: %%, align %{xxx}D with %{xxx}T#1002

Closed
fabian-hahn wants to merge 7 commits intoapache:mainfrom
fabian-hahn:main
Closed

Add access-log pattern: %%, align %{xxx}D with %{xxx}T#1002
fabian-hahn wants to merge 7 commits intoapache:mainfrom
fabian-hahn:main

Conversation

@fabian-hahn
Copy link
Copy Markdown

@fabian-hahn fabian-hahn commented May 2, 2026

  • Support for %% in access-log format string, as in Apache httpd.
  • Support for {xxx} modifiers in %D pattern (undocumented).

Down-version PR forthcoming.

@fabian-hahn fabian-hahn changed the title AccesLogValve pattern: %%, Align %{xxx}D with %{xxx}T AccessLogValve pattern: %%, Align %{xxx}D with %{xxx}T May 2, 2026
@fabian-hahn fabian-hahn changed the title AccessLogValve pattern: %%, Align %{xxx}D with %{xxx}T Add access-log pattern: %%, Align %{xxx}D with %{xxx}T May 2, 2026
markt-asf added a commit that referenced this pull request May 2, 2026
markt-asf added a commit that referenced this pull request May 2, 2026
markt-asf added a commit that referenced this pull request May 2, 2026
@fabian-hahn fabian-hahn changed the title Add access-log pattern: %%, Align %{xxx}D with %{xxx}T Add access-log pattern: %%, align %{xxx}D with %{xxx}T May 2, 2026
@markt-asf
Copy link
Copy Markdown
Contributor

Replaced by #1003

@markt-asf markt-asf closed this May 6, 2026
@markt-asf
Copy link
Copy Markdown
Contributor

Re-opening as #1002 isn't what I thought it was.

@markt-asf markt-asf reopened this May 6, 2026
markt-asf added a commit that referenced this pull request May 6, 2026
Also fix various bugs with literal handling found in JSONAccessLogValve
while writing tests for literal '%' support.

Based on #1002 by Fabian Hahn.
@markt-asf
Copy link
Copy Markdown
Contributor

Support added for '%%'.

Proposed changes to %D and %T should be discussed on the dev list.

@markt-asf markt-asf closed this May 6, 2026
markt-asf added a commit that referenced this pull request May 6, 2026
Also fix various bugs with literal handling found in JSONAccessLogValve
while writing tests for literal '%' support.

Based on #1002 by Fabian Hahn.
markt-asf added a commit that referenced this pull request May 6, 2026
Also fix various bugs with literal handling found in JSONAccessLogValve
while writing tests for literal '%' support.

Based on #1002 by Fabian Hahn.
markt-asf added a commit that referenced this pull request May 6, 2026
Also fix various bugs with literal handling found in JSONAccessLogValve
while writing tests for literal '%' support.

Based on #1002 by Fabian Hahn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants